[
https://issues.apache.org/jira/browse/GEODE-2694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966227#comment-15966227
]
ASF subversion and git services commented on GEODE-2694:
--------------------------------------------------------
Commit 60a96cc2b809ad28a21ac41e54f795274060fa04 in geode's branch
refs/heads/develop from [~eshu]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=60a96cc ]
GEODE-2694: Add test coverage on RECOVERED_FROM_DISK bit after gii.
> RECOVERED_FROM_DISK bit is cleared during gii, but should be restored if the
> recovered entry and gii entry has the same version tag
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: GEODE-2694
> URL: https://issues.apache.org/jira/browse/GEODE-2694
> Project: Geode
> Issue Type: Bug
> Components: regions
> Reporter: Eric Shu
> Assignee: Eric Shu
>
> Currently for all gii entries, product clears the RECOVERED_FROM_DISK bit for
> DiskEntry. However, if entry comes from gii has the same version as recovered
> entry, the RECOVERED_FROM_DISK bit should be restored but does not.
> {noformat}
> synchronized (re) { // fixes bug 41409
> if (dr.testIsRecoveredAndClear(re)) {
> wasRecovered = true;
> if (tmpValue == null) {
> tmpValue = entry.isLocalInvalid() ? Token.LOCAL_INVALID :
> Token.INVALID;
> }
> // Compare the version stamps, and if they are equal
> // we can skip adding the entry we receive as part of GII.
> VersionStamp stamp = re.getVersionStamp();
> boolean entriesEqual = stamp != null &&
> stamp.asVersionTag().equals(tag);
> // If the received entry and what we have in the cache
> // actually are equal, keep don't put the received
> // entry into the cache (this avoids writing a record to disk)
> if (entriesEqual) {
> continue;
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
