----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58594/#review172566 -----------------------------------------------------------
Ship it! This looks ok. The only places that call ParallelGatewaySenderQueue.destroyEventFromQueue are the AckReaderThread after a successfully processed batch and the ConflationHandler to conflate an entry. The ConflationHandler only is called by BRQ virtualPut if this.getBucketAdvisor().isPrimary(), so removing that call should be ok. Have you run conflation tests to verify? - Barry Oglesby On April 20, 2017, 9:08 p.m., xiaojian zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58594/ > ----------------------------------------------------------- > > (Updated April 20, 2017, 9:08 p.m.) > > > Review request for geode and Jason Huynh. > > > Bugs: GEODE-2806 > https://issues.apache.org/jira/browse/GEODE-2806 > > > Repository: geode > > > Description > ------- > > one of the known root causes > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java > cf4c5a9ef > > > Diff: https://reviews.apache.org/r/58594/diff/1/ > > > Testing > ------- > > > Thanks, > > xiaojian zhou > >
