Github user agingade commented on a diff in the pull request:
https://github.com/apache/geode/pull/477#discussion_r113087379
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/OverflowOplog.java ---
@@ -724,8 +727,31 @@ public final void flush() throws IOException {
if (bb != null && bb.position() != 0) {
bb.flip();
int flushed = 0;
+ int numChannelRetries = 0;
do {
- flushed += olf.channel.write(bb);
+ int channelBytesWritten = 0;
+ final int bbStartPos = bb.position();
+ final long channelStartPos = olf.channel.position();
+ // differentiate between bytes written on this channel.write()
iteration and the
+ // total number of bytes written to the channel on this call
+ channelBytesWritten += olf.channel.write(bb);
--- End diff --
Instead of "+="; we could just assign the value...Its not really makes any
difference; its just when you read this line, you don't have to know its
previous value...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
