GitHub user metatype opened a pull request:

    https://github.com/apache/geode-examples/pull/4

    Updating and simplifying examples

    These are some ideas I have to simplify our examples.  Please let me know 
what you think.
    
    You can build and run everything from the root by invoking `./gradlew 
runAll`.
    
    Each example consists of the following:
    - A `README.md` that walks the user through the tutorial
    - An `Example.java` application as well as supporting classes and tests as 
needed
    - A gfsh start script:  `scripts/start.gfsh`
    - A gfsh stop script:  `scripts/stop.gfsh`
    
    The changes in this PR support the above model.  
    
    The build script has tasks to start a cluster, run the example, and stop 
the cluster using the downloaded Geode install.  However, the README's 
reference specific gfsh commands to familiarize the user with interacting with 
Geode.
    
    I avoided using bash scripts to simplify the environment.  This means using 
the default locator port of 10334.  I also removed a number of unit tests that 
added complexity IMO.  I think the examples should be easy to extend.  If 
`gradle runAll` succeeds that should be a sufficient check to ensure that the 
example is still functioning.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/metatype/geode-examples develop

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode-examples/pull/4.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4
    
----
commit f811a1cd664d8a888bd447068d00ad98597d1bd1
Author: Anthony Baker <aba...@apache.org>
Date:   2017-04-24T19:24:47Z

    Add eclipse generator, improve formatting

commit 3da70b823815b02434519a1df4cf0c6a2b53a961
Author: Anthony Baker <aba...@apache.org>
Date:   2017-04-25T06:21:10Z

    update examples

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to