----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58849/#review173387 -----------------------------------------------------------
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ConcurrentDeployDUnitTest.java Lines 64-66 (patched) <https://reviews.apache.org/r/58849/#comment246392> Is there a particular reason for the spelling of the variables '...Invokation' vs. '...Invocation'. Misspellings of words within variable, method, etc. names don't add clarity to the code. Exceptions would be where the name might conflict with a keyword, which is not the case here. - Ken Howe On April 28, 2017, 6:02 p.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58849/ > ----------------------------------------------------------- > > (Updated April 28, 2017, 6:02 p.m.) > > > Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick > Rhomberg. > > > Repository: geode > > > Description > ------- > > GEODE-2840: add a DUnit test to test concurrent deploy > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/internal/DeployedJar.java > f96863f66ab2c853567ba6ffdbe3da47c9bcbdb7 > geode-core/src/main/java/org/apache/geode/internal/JarDeployer.java > a65cd0f550a9cf5a93ae890c094e5f5c6e2908df > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ConcurrentDeployDUnitTest.java > PRE-CREATION > geode-core/src/test/java/org/apache/geode/test/dunit/rules/JarFileRule.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java > 34506c4fa803a1121c29d240ad7d7aa6a55dca99 > > > Diff: https://reviews.apache.org/r/58849/diff/1/ > > > Testing > ------- > > precheckin running > > > Thanks, > > Jinmei Liao > >
