----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58853/#review173555 -----------------------------------------------------------
Fix it, then Ship it! fix and ship it. geode-core/src/main/java/org/apache/geode/internal/cache/EventTracker.java Line 545 (original), 546 (patched) <https://reviews.apache.org/r/58853/#comment246542> It's better to initialize it to null. Fix and commit. geode-core/src/main/java/org/apache/geode/internal/cache/EventTracker.java Line 561 (original), 560 (patched) <https://reviews.apache.org/r/58853/#comment246545> you don't need to remove here since you have "finally" - xiaojian zhou On May 2, 2017, 1 a.m., Eric Shu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58853/ > ----------------------------------------------------------- > > (Updated May 2, 2017, 1 a.m.) > > > Review request for geode, anilkumar gingade, Darrel Schneider, and Lynn > Gallinat. > > > Bugs: GEODE-2847 > https://issues.apache.org/jira/browse/GEODE-2847 > > > Repository: geode > > > Description > ------- > > Get correct version tags from recordedBulkOpVersionTags in eventTracker. > Do not remove the recordedBulkOpVersionTags prematurely. > Add the unit test which would fail without the fixes. > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/internal/cache/EventTracker.java > 2ddfdc4 > geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java > 8c061b0 > > geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PutAllPRMessage.java > 27f5aa0 > > geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RemoveAllPRMessage.java > f4f6299 > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProxyMembershipID.java > 2cbf63b > > geode-core/src/test/java/org/apache/geode/internal/cache/AbstractDistributedRegionJUnitTest.java > ba2f794 > > geode-core/src/test/java/org/apache/geode/internal/cache/DistributedRegionJUnitTest.java > 7525f35 > > geode-core/src/test/java/org/apache/geode/internal/cache/EventTrackerTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/58853/diff/2/ > > > Testing > ------- > > precheckin. > > > Thanks, > > Eric Shu > >
