Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode/pull/502#discussion_r115623329
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegionQueue.java
---
@@ -71,10 +73,10 @@
private final Map indexes;
/**
- * A transient queue to maintain the eventSeqNum of the events that are
to be sent to remote site.
- * It is cleared when the queue is cleared.
+ * A transient deque, but should be treated like as a fifo queue to
maintain the eventSeqNum of
+ * the events that are to be sent to remote site. It is cleared when the
queue is cleared.
*/
- private final BlockingQueue<Object> eventSeqNumQueue = new
LinkedBlockingQueue<Object>();
+ private final BlockingDeque<Object> eventSeqNumDeque = new
LinkedBlockingDeque<Object>();
--- End diff --
Does this really have to be a Deque of type Object?? Don't we know what
type of objects we are putting in here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
