[
https://issues.apache.org/jira/browse/GEODE-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005539#comment-16005539
]
ASF GitHub Bot commented on GEODE-2788:
---------------------------------------
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/474
Masaki, this change set is breaking unit tests because the new XSD
attribute is being put into XML files generated for older versions.
CacheXml80DUnitTest, for instance, is breaking. l80Please run the precheckin
target before posting a fix and ensure that you're not breaking anything.
Thanks
You should also add a test case in CacheXmlGeode10DUnitTest for the new
attribute.
org.apache.geode.cache30.CacheXml80DUnitTest > testDefaultConnectionPool
FAILED
org.apache.geode.cache.CacheXmlException: While reading Cache XML
file:/export/india2/users/bschuchardt/devel/gfdev/open/geode-core/build/distributedTest/XML_8_0/CacheXml80DUnitTest_testDefaultConnectionPool.xml.
Error while parsing XML, caused by org.xml.sax.SAXParseException; lineNumber:
4; columnNumber: 528; Attribute "socket-connect-timeout" must be declared for
element type "pool".
org.xml.sax.SAXParseException; lineNumber: 4; columnNumber: 528;
Attribute "socket-connect-timeout" must be declared for element type "pool".
java.lang.AssertionError: Suspicious strings were written to the log
during this run.
Fix the strings or use IgnoredException.addIgnoredException to ignore.
-----------------------------------------------------------------------
Found suspect string in log4j at line 91
[error 2017/05/10 12:12:11.923 PDT <Test worker> tid=0x13] While
reading Cache XML
file:/export/india2/users/bschuchardt/devel/gfdev/open/geode-core/build/distributedTest/XML_8_0/CacheXml80DUnitTest_testDefaultConnectionPool.xml.
Error while parsing XML
> Add official Socket timeout parameter when connecting to servers/locators
> -------------------------------------------------------------------------
>
> Key: GEODE-2788
> URL: https://issues.apache.org/jira/browse/GEODE-2788
> Project: Geode
> Issue Type: Improvement
> Components: client/server, docs
> Reporter: Masaki Yamakawa
> Priority: Minor
> Labels: patch
>
> When connecting from the client to the servers/locators, if the
> servers/locators is not started, the connection can not be established and a
> Socket timeout occurs.
> This timeout value is 59 seconds by default. This timeout value is too long.
> This timeout value can be changed by specifying the unofficial parameter
> "gemfire.PoolImpl.HANDSHAKE_TIMEOUT" in java system property, but I
> corresponded so that it can be specified by official parameters.
> Like the NativeClient, the official parameters should be specified by
> "connect-timeout" in gemfire.properties.
> Timeout values are determined in the following order of priority.
> 1. java system property:gemfire.PoolImpl.HANDSHAKE_TIMEOUT
> 2. java system property:gemfire.connect-timeout
> 3. gemfire.properties:connect-timeout
> 4. default:59000 milli seconds
> As another idea, there is also an idea to make it possible to specify it as
> an attribute of Pool. In that case NativeClient needs the same modification.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
