Github user bschuchardt commented on the issue: https://github.com/apache/geode/pull/474 There is another failure in AnalyzeSerializablesJUnitTest caused by this change. Certain tests serilalize/deserialize PoolAttributes, so this class is DataSerializable. This PR changes the serialized form of the class, so the sanctionedSerializables.txt file must be updated to reflect that this change is acceptable: org.apache.geode.codeAnalysis.AnalyzeSerializablesJUnitTest > testDataSerializables FAILED java.lang.AssertionError: Modified classes-------------------------------------------- org/apache/geode/internal/cache/PoolFactoryImpl$PoolAttributes,2 fromData,153,2a2bb80034b500052a2bb80034b500072a2bb80034b500092a2bb80034b5000b2a2bb80034b5000c2a2bb80034b5000d2a2bb80034b500112a2bb80035b500102a2bb80035b500142a2bb80034b500182a2bb80034b5001a2a2bb80036b5000a2a2bb80036b500162a2bb80037b5001d2a2bb80038b500212a2bb80038b500222a2bb80034b500152a2bb80036b5001e2a2bb80034b50004b1 toData,153,2ab400052bb8002f2ab400072bb8002f2ab400092bb8002f2ab4000b2bb8002f2ab4000c2bb8002f2ab4000d2bb8002f2ab400112bb8002f2ab400102bb800302ab400142bb800302ab400182bb8002f2ab4001a2bb8002f2ab4000a2bb800312ab400162bb800312ab4001d2bb800322ab400212bb800332ab400222bb800332ab400152bb8002f2ab4001e2bb800312ab400042bb8002fb1 : toData (len=153,expected=145), and fromData (len=153,expected=145) If the class is not persisted or sent over the wire add it to the excludedClasses.txt file in the org/apache/geode/codeAnalysis directory. Otherwise if this doesn't break backward compatibility move the file actualDataSerializables.dat to the codeAnalysis test directory and rename to sanctionedDataSerializables.txt at org.junit.Assert.fail(Assert.java:88) at org.apache.geode.codeAnalysis.AnalyzeSerializablesJUnitTest.testDataSerializables(AnalyzeSerializablesJUnitTest.java:188)
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---