----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59239/#review175022 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java Line 269 (original), 307 (patched) <https://reviews.apache.org/r/59239/#comment248339> Why are these locators "bad"... It is just the initial configured list of locators.. geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java Lines 350 (patched) <https://reviews.apache.org/r/59239/#comment248338> Why do we name this "badLocators"? Really it's is a merge of 2 lists of InetSocketAddress... geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java Lines 148 (patched) <https://reviews.apache.org/r/59239/#comment248343> It isn't immediately evident why `floc1` is not equal to the `floc1` that is updated in `src.updateLocatorInLocatorList`. Also maybe a `==` instance comparison is better than identityHashCode - Udo Kohlmeyer On May 15, 2017, 8:46 p.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59239/ > ----------------------------------------------------------- > > (Updated May 15, 2017, 8:46 p.m.) > > > Review request for geode, Bruce Schuchardt, Galen O'Sullivan, and Udo > Kohlmeyer. > > > Repository: geode > > > Description > ------- > > GEODE-2804 Update InetSocketAddress, when there is IOException. > > Geode keeps InetSocketAddress for locators. So, if locators ip > changes in cloud/VM enviroment then Geode process unable to > connect to locator. Thus we have fixed this problem in two way. > > a. If Geode client sees IOException while connectin to locator then > we change cached InetAddress to use locator hostname. In this way, > client does DNS query again for locator host. > b. For other Geode process, now we connect to locator using hostname. > > Added couple of junit tests for it. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImpl.java > 1e807ee > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java > 4bf010b > > geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpClient.java > 6b54170 > > geode-core/src/main/java/org/apache/geode/management/internal/JmxManagerLocatorRequest.java > 0efba01 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java > d61e72d > > geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java > 385569c > > > Diff: https://reviews.apache.org/r/59239/diff/3/ > > > Testing > ------- > > > Thanks, > > Hitesh Khamesra > >
