----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59287/#review175282 -----------------------------------------------------------
On a Mac, Alt-Shift-I does all the inspections for the current file. It's how I find all the typos that bother me so. geode-core/src/main/java/org/apache/geode/distributed/internal/membership/InternalDistributedMember.java Line 28 (original), 28 (patched) <https://reviews.apache.org/r/59287/#comment248730> Are star-imports frowned upon? IntelliJ optimizes imports to... ``` import org.apache.geode.DataSerializer; import org.apache.geode.GemFireConfigException; import org.apache.geode.InternalGemFireError; import org.apache.geode.cache.UnsupportedVersionException; import org.apache.geode.distributed.DistributedMember; import org.apache.geode.distributed.DurableClientAttributes; import org.apache.geode.distributed.Role; import org.apache.geode.distributed.internal.DistributionAdvisor.ProfileId; import org.apache.geode.distributed.internal.DistributionConfig; import org.apache.geode.distributed.internal.DistributionManager; import org.apache.geode.distributed.internal.ServerLocation; import org.apache.geode.internal.Assert; import org.apache.geode.internal.DataSerializableFixedID; import org.apache.geode.internal.InternalDataSerializer; import org.apache.geode.internal.OSProcess; import org.apache.geode.internal.Version; import org.apache.geode.internal.cache.versions.VersionSource; import org.apache.geode.internal.i18n.LocalizedStrings; import org.apache.geode.internal.net.SocketCreator; import java.io.DataInput; import java.io.DataOutput; import java.io.EOFException; import java.io.Externalizable; import java.io.IOException; import java.io.ObjectInput; import java.io.ObjectOutput; import java.net.InetAddress; import java.net.UnknownHostException; import java.util.Arrays; import java.util.Collections; import java.util.HashSet; import java.util.List; import java.util.Set; ``` geode-core/src/main/java/org/apache/geode/distributed/internal/membership/InternalDistributedMember.java Line 34 (original), 34 (patched) <https://reviews.apache.org/r/59287/#comment248729> This import can be removed. geode-core/src/main/java/org/apache/geode/distributed/internal/membership/InternalDistributedMember.java Line 1208 (original), 1208 (patched) <https://reviews.apache.org/r/59287/#comment248727> InternalDistrubtedMemberWrapper -> InternalDistributedMemberWrapper geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommand.java Lines 158 (patched) <https://reviews.apache.org/r/59287/#comment248737> availble -> available geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommandTest.java Line 107 (original), 128 (patched) <https://reviews.apache.org/r/59287/#comment248734> mockFuntionExecutor -> mockFunctionExecutor geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommandTest.java Lines 139 (patched) <https://reviews.apache.org/r/59287/#comment248735> mockFuntionExecutor -> mockFunctionExecutor geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommandTest.java Lines 150 (patched) <https://reviews.apache.org/r/59287/#comment248736> mockFuntionExecutor -> mockFunctionExecutor geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnitTest.java Line 41 (original), 42 (patched) <https://reviews.apache.org/r/59287/#comment248732> This import can be removed. geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunctionCacheTest.java Lines 92-95 (original), 90-93 (patched) <https://reviews.apache.org/r/59287/#comment248738> initalFileSizes -> initialFileSizes - Patrick Rhomberg On May 15, 2017, 10:09 p.m., Ken Howe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59287/ > ----------------------------------------------------------- > > (Updated May 15, 2017, 10:09 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, Kirk Lund, and Patrick > Rhomberg. > > > Repository: geode > > > Description > ------- > > Adds 'export logs' option, --file-limit-size, to allow user to set > maximun size of the epxorted logs zip file. > > When size checking is enabled (file-limit-size > 0) then the check > will also prevent filling up the disk on each member while consolidating > and filtering the logs. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/distributed/internal/membership/InternalDistributedMember.java > 41c85d6421c8283163b70f2a560c8e4cbb02f2cc > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommand.java > 20ec1f5702aea341ace5aa3b103c34cbdce1ae87 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunction.java > 8d20dc05c14bf558462893c4dd4cbbc474df4077 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/util/LogSizer.java > 0a799f6c85dada2791da57585234fa2e47ef0b3d > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommandTest.java > a02c07f2c28156e097306f4b57174cddeda78845 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsDUnitTest.java > 96ac76588662b1de5d5bf41c24ab115d90fc0a85 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsFileSizeLimitTest.java > ec2bcfe8ea876172c6946c43c005659d23d055e0 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportLogsTestSuite.java > 90a92f33247ecec8ee300ecb80a5d8ab27193c94 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/SizeExportLogsFunctionCacheTest.java > d8f2f2db937fc51ab5f917659e766f338b9ae847 > > > Diff: https://reviews.apache.org/r/59287/diff/2/ > > > Testing > ------- > > Precheckin is in progress - all green so far with only DistributedTest still > running > > > Thanks, > > Ken Howe > >
