Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/500#discussion_r117081706
--- Diff:
geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java
---
@@ -145,6 +153,7 @@ public void startServer(boolean pdxPersistent) {
CacheFactory cf = new CacheFactory(this.properties);
cf.setPdxReadSerialized(pdxPersistent);
cf.setPdxPersistent(pdxPersistent);
+ this.pdxPersistent = pdxPersistent;
--- End diff --
I don't think we should add this line here.
we can get rid of this "public void startServer(boolean pdxPersistent)"
method now since we have withPdxPersistant added. the flag should solely be
determined by the value of the member variable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
