[ https://issues.apache.org/jira/browse/GEODE-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021538#comment-16021538 ]
ASF GitHub Bot commented on GEODE-231: -------------------------------------- Github user dschneider-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/507#discussion_r118060767 --- Diff: geode-junit/src/main/java/org/apache/geode/test/junit/rules/UseJacksonForJsonPathRule.java --- @@ -14,19 +14,18 @@ */ package org.apache.geode.test.junit.rules; -import java.util.EnumSet; -import java.util.Set; --- End diff -- I see no reason why this import reorg should be part of this pull request. > Remove deprecated AttributesMutator.setCacheListener > ---------------------------------------------------- > > Key: GEODE-231 > URL: https://issues.apache.org/jira/browse/GEODE-231 > Project: Geode > Issue Type: Sub-task > Reporter: Darrel Schneider > Assignee: Shankar Hundekar > Original Estimate: 4h > Remaining Estimate: 4h > > It looks like AttributesMutator.setCacheListener is currently only called > from test code. All of these calls can be replaced with > AttributesMutator.initCacheListeners with an array of one listener. > It is probably not safe to use AttributesMutator.addCacheListener since it > leaves an original listeners in place. > The method is called in about 25 different tests. -- This message was sent by Atlassian JIRA (v6.3.15#6346)