----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59492/#review175824 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/AbstractCommandsSupport.java Lines 134 (patched) <https://reviews.apache.org/r/59492/#comment249156> I wonder if it would be better to move these mbean finder methods to their own class specific to finding mbeans? These would be useful outside of cli commands. geode-core/src/main/java/org/apache/geode/management/internal/configuration/utils/SharedConfiguration.java Lines 30 (patched) <https://reviews.apache.org/r/59492/#comment249157> Maybe name this ClusterConfiguration instead? - Kirk Lund On May 23, 2017, 5:01 p.m., Jared Stewart wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59492/ > ----------------------------------------------------------- > > (Updated May 23, 2017, 5:01 p.m.) > > > Review request for geode, Jinmei Liao, Ken Howe, Kirk Lund, and Patrick > Rhomberg. > > > Repository: geode > > > Description > ------- > > - Extract several commands out of LauncherLifecycleCommands into their > distinct own classes. > - Extract some utility methods from LauncherLifecycleCommands into more > appropriate locations. > > > Diffs > ----- > > > geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsDUnitTest.java > 27bc098d77c05d7385856e6fa4b769a7a2247a0e > > geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsTest.java > 2a1662e318986b1520940403e7c881a2713c8920 > geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java > ce660578f4ddef1e733562e94f84a944cf1d3427 > geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java > 12c5c2154a2e95fcd45c0414bb7f46add07e5973 > geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java > a6d3064404a247f5d669ea7aff0cdd37e11e4583 > > geode-core/src/main/java/org/apache/geode/internal/process/ProcessStreamReader.java > 18fca984b5792f096cc8b1755b09e65efbdd0d05 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/AbstractCommandsSupport.java > 26b903b3895f7f01f01684c44cc320129c80f81e > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java > b6c11c42731b4158dc16db3586c2a0ba9c5d7b79 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJConsoleCommand.java > PRE-CREATION > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJVisualVMCommand.java > PRE-CREATION > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartPulseCommand.java > PRE-CREATION > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartVsdCommand.java > PRE-CREATION > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StatusLocatorCommand.java > PRE-CREATION > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StatusServerCommand.java > PRE-CREATION > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StopLocatorCommand.java > PRE-CREATION > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/lifecycle/StopServerCommand.java > PRE-CREATION > > geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java > 68d055cbd61ca35ef7409ff3370214a005da3d9b > > geode-core/src/main/java/org/apache/geode/management/internal/cli/util/HostUtils.java > PRE-CREATION > > geode-core/src/main/java/org/apache/geode/management/internal/cli/util/JdkTool.java > PRE-CREATION > > geode-core/src/main/java/org/apache/geode/management/internal/configuration/utils/SharedConfiguration.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/lifecycle/StartJConsoleCommandTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/management/internal/cli/util/HostUtilsTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/management/internal/cli/util/JdkToolTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/59492/diff/1/ > > > Testing > ------- > > Precheckin running > > > Thanks, > > Jared Stewart > >
