[
https://issues.apache.org/jira/browse/GEODE-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021961#comment-16021961
]
ASF GitHub Bot commented on GEODE-1994:
---------------------------------------
GitHub user PurelyApplied opened a pull request:
https://github.com/apache/geode/pull/528
GEODE-1994, revisited: Removed guaranteed failures.
Removed two uses of ServerLauncher.Builder.setMemberName that are
guaranteed to throw under the changes introduced by GEODE-1994.
With the previous update to StringUtils,
ServerLauncher.Builder.setMemberName throws when its input is blank. These two
uses are behind conditionals and only occur when the member name is blank,
guaranteeing failure. This results in the `status server` and `stop server`
commands functioning only when `--name` is used, but failing with `--dir` and
`--pid`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PurelyApplied/geode geode-1994.revised
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/528.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #528
----
commit 071780ed1aa2b12068f12291d032c30a930320ac
Author: Patrick Rhomberg <prhomb...@pivotal.io>
Date: 2017-05-23T22:07:11Z
GEODE-1994, revisited: Removed two references to
ServerLauncher.setMemberName that are guaranteed to throw under the changes
introduced by GEODE-1994.
----
> Change geode StringUtils to extend commons StringUtils
> ------------------------------------------------------
>
> Key: GEODE-1994
> URL: https://issues.apache.org/jira/browse/GEODE-1994
> Project: Geode
> Issue Type: Wish
> Components: general, management
> Reporter: Kirk Lund
> Assignee: Patrick Rhomberg
>
> org.apache.geode.internal.lang.StringUtils duplicates some of the methods in
> org.apache.commons.lang.StringUtils with some inconsistencies.
> isBlank is implemented identically
> isEmpty is inconsistent -- commons version returns true if string is null,
> while geode version returns false if string is null
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
