[ 
https://issues.apache.org/jira/browse/GEODE-2818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025357#comment-16025357
 ] 

ASF GitHub Bot commented on GEODE-2818:
---------------------------------------

GitHub user YehEmily opened a pull request:

    https://github.com/apache/geode/pull/539

    GEODE-2818: add alias to any command's options that involves "group", 
"member", "jar"

    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
    
    - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    - [ ] Does `gradlew build` run cleanly?
    
    - [ ] Have you written or updated unit tests to verify your changes?
    
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
    submit an update to your PR as soon as possible. If you need help, please 
send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/YehEmily/geode synonyms

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/539.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #539
    
----
commit 01c5119654f27a254f8fb334b9fe8a2d5c4039ac
Author: YehEmily <emilyyeh1...@gmail.com>
Date:   2017-05-23T19:27:40Z

    GEODE-2977: make group/name option values consistent

commit 2076f03d8cd3748f204518c47b3a6245f9f6a714
Author: YehEmily <emilyyeh1...@gmail.com>
Date:   2017-05-25T19:18:45Z

    Edited command files to allow either 'group' or 'groups' and 'member' or 
'members

----


> add alias to any command's options that involves "group", "member", "jar"
> -------------------------------------------------------------------------
>
>                 Key: GEODE-2818
>                 URL: https://issues.apache.org/jira/browse/GEODE-2818
>             Project: Geode
>          Issue Type: New Feature
>          Components: docs, gfsh
>            Reporter: Jinmei Liao
>
> Or anything that would have confusion about if we are going to use singular 
> or plural at all.
> 1) add alias for those options
> 2) make sure it parameter type is an array type, some method only accepts a 
> string and split it inside the command.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to