[ https://issues.apache.org/jira/browse/GEODE-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030212#comment-16030212 ]
ASF GitHub Bot commented on GEODE-2203: --------------------------------------- Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/549#discussion_r119225797 --- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java --- @@ -1794,18 +1801,20 @@ public Result statusServer( .format(CliStrings.STATUS_SERVICE__GFSH_NOT_CONNECTED_ERROR_MESSAGE, "Cache Server")); } } else { - final ServerLauncher serverLauncher = new ServerLauncher.Builder() - .setCommand(ServerLauncher.Command.STATUS).setDebug(isDebugging()) - // NOTE since we do not know whether the "CacheServer" was enabled or not on the GemFire - // server when it was started, set the disableDefaultServer property in the - // ServerLauncher.Builder to default status - // to the MemberMBean - // TODO fix this hack! (how, the 'start server' loop needs it) - .setDisableDefaultServer(true).setPid(pid).setWorkingDirectory(workingDirectory) - .build(); - + final ServerLauncher serverLauncher; + if ((member == null)) { --- End diff -- Oops, that's very true - thanks! I'll update the PR. > gfsh status locator/server - Give more descriptive output on empty parameter > ---------------------------------------------------------------------------- > > Key: GEODE-2203 > URL: https://issues.apache.org/jira/browse/GEODE-2203 > Project: Geode > Issue Type: Improvement > Components: gfsh > Reporter: Alyssa Kim > Assignee: Emily Yeh > Priority: Minor > Labels: StatusLocatorCommand, StatusServerCommand, gfsh, status > > Currently, executing some status commands in gfsh without valid parameters > gives a vague explanation/output that might be misleading. Although we have > help <command_name> for usage description, displaying 'null' as an output > might not be the best idea. > Current Result > {code} > gfsh>status locator > null > {code} > {code} > gfsh>status server > Server in > C:\Users\XXX\git\incubator-geode\geode-assembly\build\install\apache-geode\bin > on null is currently not responding. > {code} > Improvement > {code} > gfsh>status locator > SYNTAX > status locator [--name=value] [--host=value] [--port=value] [--pid=value] > Use help status locator to display detailed usage information > {code} > {code} > gfsh>status server > SYNTAX > status server [--name=value] [--pid=value] [--dir=value] > Use help status server to display detailed usage information > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)