GitHub user PurelyApplied opened a pull request:
https://github.com/apache/geode/pull/551
GEODE-2971: consistency in shell exit codes for status commands.
* Replaced all System.exit parameters with ShellExitCode references for
extensibility
* Added FakeLaunchers to Locator- and ServerStarterRules to spoof member
status and to register the instance to the Launcher class. The spoofed status
is of mixed reliability and only used when connected via jmx (via `--name`, not
`--dir` or `--pid`).
* Expanded starter rules to spawn PID files in working directory.
* Made `getMemberMXBean` static, added public `isMemberMXBeanAvailable` to
allow tests to delay tests until server is ready.
* Code cleanup of touched files.
Precheckin ran nearly-fully-green. One test failure which I suspect to be
unrelated to these changes. This test passed cleanly when run with `gradlew
-distributedTest.single=...`. Currently rerunning DUnits together to verify.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PurelyApplied/geode gem-1370
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/551.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #551
----
commit 91ee3d79102fafa9521a219aa8d3527bea519922
Author: Patrick Rhomberg <[email protected]>
Date: 2017-05-30T21:25:47Z
GEODE-2971: consistency in shell exit codes for status commands.
* Replaced all System.exit calls with ShellExitCode references for
extensibility
* Added FakeLaunchers to Locator- and ServerStarterRules to spoof member
status made via jmx (not --pid or --dir options)
* Expanded starter rules to spawn PID files
* Made getMemberMXBean static, made public isMemberMXBeanAvailable to delay
tests until server is ready.
* Code cleanup of touched files.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
