[
https://issues.apache.org/jira/browse/GEODE-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16033277#comment-16033277
]
ASF subversion and git services commented on GEODE-2966:
--------------------------------------------------------
Commit cfdd57378fb78cbc98d41446752460f534b28db7 in geode's branch
refs/heads/release/1.2.0 from [~jstewart]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=cfdd573 ]
GEODE-2966: RefactorLauncherLifecycleCommands
- Extract several commands into their own classes.
- Extract utility methods into their own classes.
- Rename AbstractCommandsSupport to GfshCommand, and convert it from an
abstract class to an interface
(cherry picked from commit 9046c8d)
> Refactor LauncherLifecycleCommands
> ----------------------------------
>
> Key: GEODE-2966
> URL: https://issues.apache.org/jira/browse/GEODE-2966
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh, management
> Reporter: Jared Stewart
> Assignee: Jared Stewart
> Fix For: 1.3.0
>
>
> LauncherLifecycleCommands is over 2000 lines of code, and could be made a lot
> more readable by introducing proper OO abstraction. There are also many
> private static final strings like {{CliStrings.START_LOCATOR__MEMBER_NAME}}
> that could be made shorter and more contextual, e.g.
> {{StartLocatorCommand.MEMBER_NAME}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
