----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59926/#review177413 -----------------------------------------------------------
Ship it! Ship It! - Barry Oglesby On June 8, 2017, 6:43 p.m., xiaojian zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59926/ > ----------------------------------------------------------- > > (Updated June 8, 2017, 6:43 p.m.) > > > Review request for geode, Barry Oglesby and Dan Smith. > > > Bugs: GEODE-3055 > https://issues.apache.org/jira/browse/GEODE-3055 > > > Repository: geode > > > Description > ------- > > There's time window that data region bucket is ready, but shadow key's bucket > is not. So the event will be added into tempQueue at that windows. > > If we run waitUntilFlush during that window, it did not check the tempQueue > since its brq is not exist yet. It will cause data mismatch (i.e. we found > the key in data region, but not in index) > > We should pass in the data region's bucket list and let it wait until these > tempQueue are empty. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/AsyncEventQueueImpl.java > bf7e87445 > > geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java > c38d5475a > > geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/WaitUntilParallelGatewaySenderFlushedCoordinator.java > 42ce68cab > > geode-core/src/test/java/org/apache/geode/internal/cache/wan/parallel/WaitUntilParallelGatewaySenderFlushedCoordinatorJUnitTest.java > 5e12ed5ab > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunction.java > e11384c59 > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunctionJUnitTest.java > f92a296f7 > > > Diff: https://reviews.apache.org/r/59926/diff/1/ > > > Testing > ------- > > > Thanks, > > xiaojian zhou > >
