----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59692/ -----------------------------------------------------------
(Updated June 12, 2017, 2:44 p.m.) Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg. Changes ------- While rebasing this changeset to develop to pick up Kirk's security work, I got a bit carried away in refactoring. Below are the main points of this changeset: 1) move the creation of the security service back to GemfireCacheImpl, so that the security manager property recevied in the cluster configuration will take effect. (mainly reverted the changes under distributed.internal.membership package) 2) consolidate the implementation of SecurityService into two: IntegratedSecurityService and LegacySecurityService to avoid code duplication. 3) added default implemenation of SecurityService (debateble) 4) reworked SecurityServicefactory and add more tests. Repository: geode Description ------- GEODE-2925: add target for resource operation for finer grained security Diffs (updated) ----- geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 9b23f6c1a8ed3449d8a49029d6364f1e989e367c geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java 2988ffd43ae1985c527a1082d91b2782b03eced0 geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java 22edb6f06c7791929cc9a033ca1a1bfed5751a47 geode-core/src/main/java/org/apache/geode/distributed/internal/SecurityConfig.java deea55ff085762a2dd91ebdc57475e42724dee04 geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberFactory.java b682d93fd5c4b5340e2c30be72c5572e031e26ed geode-core/src/main/java/org/apache/geode/distributed/internal/membership/MemberServices.java c52ccbc1cc5a293d70b177e38ddddf03dc17c7db geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/GMSMemberFactory.java 01d99951bc70547fb311f2edbfec8dde1be799f7 geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/Services.java 2d6af1a22644d427ec2d17863cef27a8d8961491 geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/auth/GMSAuthenticator.java f895b964794f99127f1f0c9564f3f85213e0af22 geode-core/src/main/java/org/apache/geode/examples/security/ExampleSecurityManager.java 84f97de565a8301168f13e1917ea739a8879162c geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 40df0c7dcac8827a381c268c1f90e6acfb97a7f1 geode-core/src/main/java/org/apache/geode/internal/security/CallbackInstantiator.java 3ff632d3857189513243959ee96da89da66d5a27 geode-core/src/main/java/org/apache/geode/internal/security/CustomSecurityService.java c4946e768ee70db00030defa76da7d21d33c6e0c geode-core/src/main/java/org/apache/geode/internal/security/DisabledSecurityService.java d328946632c1d0defc86aa0527208a841b9b45ba geode-core/src/main/java/org/apache/geode/internal/security/EnabledSecurityService.java f971deef0807534a014236d37ba48bafa307c56b geode-core/src/main/java/org/apache/geode/internal/security/LegacySecurityService.java ef92bb7415c05ae09511e38d8a850f386de23033 geode-core/src/main/java/org/apache/geode/internal/security/SecurityService.java be81582b74a4359f74d483ca64c6e42f6b081738 geode-core/src/main/java/org/apache/geode/internal/security/SecurityServiceFactory.java 02f34f15617f7bf4ad9ee7fa51f32be4db3c198a geode-core/src/main/java/org/apache/geode/internal/security/SecurityServiceType.java 8ae76d22b628b3175db45116b80dfcfbe34aba1d geode-core/src/main/java/org/apache/geode/internal/security/shiro/ConfigInitializer.java 60f014b9c33732a4ea134a654e666a9439b210bb geode-core/src/main/java/org/apache/geode/internal/security/shiro/CustomAuthRealm.java 51449fdd5570494f3cf91325985a5eb9fc9f6d57 geode-core/src/main/java/org/apache/geode/internal/security/shiro/RealmInitializer.java 978c4dd0ab92afde53972f7feb9d8f018d0bf662 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java 64fafda8437e06de818ead40731818f937c3aef5 geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/CommandProcessor.java 7ec7699821c9f5572aebeb0936ad3617e802c07e geode-core/src/main/java/org/apache/geode/management/internal/security/AccessControlMBean.java 365c6ae01994cd0d5c06e523c42b6bec19c14c5d geode-core/src/main/java/org/apache/geode/management/internal/security/MBeanServerWrapper.java 345d688c10c0477904ceb4c5a52302b7bd3eaec9 geode-core/src/main/java/org/apache/geode/management/internal/security/ResourceOperation.java db3a1872a87b558772902cf14580f3e14fca97b3 geode-core/src/main/java/org/apache/geode/security/ResourcePermission.java 45da464419779773c9116d824fcf11774bafbd79 geode-core/src/test/java/org/apache/geode/distributed/internal/membership/MembershipJUnitTest.java a0c3cf3074051990cc50755131f8024db0b1faad geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/auth/AbstractGMSAuthenticatorTestCase.java e8c4e73e8708c3e917ddb48099f65bf315d4c3d4 geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocatorRecoveryJUnitTest.java 40c058b1548d669d8c12da5dbced9b4ffe6d63f9 geode-core/src/test/java/org/apache/geode/internal/security/DisabledSecurityServiceTest.java cacbeed957c3b87d08c93db74e38e0134565f699 geode-core/src/test/java/org/apache/geode/internal/security/EnabledSecurityServiceTest.java fca7eae9413cee98d351db5349fd950d3aa56180 geode-core/src/test/java/org/apache/geode/internal/security/FakePostProcessor.java 70823443b5c4f776c86bb28ed49a73e690c5c872 geode-core/src/test/java/org/apache/geode/internal/security/FakeSecurityManager.java ca4e6b7fb462bb4e3fefbc5db8a9503c6b13a865 geode-core/src/test/java/org/apache/geode/internal/security/IntegratedSecurityServiceConstructorTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/internal/security/LegacySecurityServiceTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/internal/security/SecurityServiceFactoryShiroIntegrationTest.java 89070123978c22c4cfa8684fbb5b033dc9d83ffa geode-core/src/test/java/org/apache/geode/internal/security/SecurityServiceFactoryTest.java f027a4367b38681f83dad2d4c4add67759633644 geode-core/src/test/java/org/apache/geode/internal/security/SecurityServiceTest.java 44893520962331bcd41e972afa661538c28d4fb2 geode-core/src/test/java/org/apache/geode/internal/security/shiro/ConfigInitializerIntegrationTest.java 857c0be8940b4acde2aa4992fac0122b687391c2 geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigWithSecurityDUnitTest.java c551ca9104a85dcf54c0bebbc4178fce4114a416 geode-core/src/test/java/org/apache/geode/management/internal/security/ResourcePermissionTest.java b728b271efb876d471b35e002c5b110919f10fcc geode-core/src/test/java/org/apache/geode/management/internal/security/SecurityServiceWithCustomRealmIntegrationTest.java 01d6bb6488e76fb3cf652ad211e9f7e2fac51389 geode-core/src/test/java/org/apache/geode/management/internal/security/SecurityServiceWithShiroIniIntegrationTest.java 1caedbcede239d6a96640381cc6941948637b442 geode-core/src/test/java/org/apache/geode/management/internal/security/TestCommand.java 3f8f4d9d4ee0a8f9c3385cd66ee20655d126d34d geode-core/src/test/java/org/apache/geode/security/CacheFactoryWithSecurityObjectTest.java cdb90f1b580edaf6a2762883d4159a45d69c4728 geode-core/src/test/java/org/apache/geode/security/ClusterConfigWithoutSecurityDUnitTest.java e90bc0a69222998322e02fcfad1b6bad3c97f4d1 geode-core/src/test/java/org/apache/geode/security/SecurityManagerLifecycleDistributedTest.java a9048b9219a494f61e3873ee3f2908da04bf6154 geode-core/src/test/java/org/apache/geode/security/SimpleSecurityManagerTest.java 1c73b577210fda43dd01ed695107310331a8c38c geode-core/src/test/java/org/apache/geode/security/TestSecurityManager.java 6080b5de8c4b11f013d0800baf2a1d9f18cb7f1d geode-core/src/test/java/org/apache/geode/test/fake/Fakes.java af38a1c37a090b3c681fc0ddca14e0a728d02057 geode-core/src/test/resources/org/apache/geode/codeAnalysis/excludedClasses.txt 9cff80d1982bd30f6ba5d8a61ab7307a69862fd4 geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/Server.java 63f907cb007846626a9a66dc6b1ef28e0bb6db45 geode-pulse/src/test/java/org/apache/geode/tools/pulse/tests/rules/ServerRule.java 767588d3717fccbb0b9c7dec7c5439e16d5381aa geode-web-api/src/main/java/org/apache/geode/rest/internal/web/security/RestSecurityService.java 6d6694721c2715d47c062de83fc0f9827411dbd7 Diff: https://reviews.apache.org/r/59692/diff/8/ Changes: https://reviews.apache.org/r/59692/diff/7-8/ Testing ------- precheckin runing Thanks, Jinmei Liao
