----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59961/#review177620 -----------------------------------------------------------
Ship it! geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/RequiresGeodeHome.java Lines 28 (patched) <https://reviews.apache.org/r/59961/#comment251315> Many of us are in the habit of putting '\n' in message strings, but I think using LINE_SEPARATOR would be better. - Ken Howe On June 9, 2017, 11:35 p.m., Jared Stewart wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59961/ > ----------------------------------------------------------- > > (Updated June 9, 2017, 11:35 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > ------- > > GEODE-3048: Introduce a rule to identify tests that require GEODE_HOME > > - A subsequent commit will add this rule to all of the relevant tests. > > > Diffs > ----- > > > geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/RequiresGeodeHome.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/59961/diff/1/ > > > Testing > ------- > > > Thanks, > > Jared Stewart > >
