Github user gregt5259 commented on the issue:
https://github.com/apache/geode-native/pull/106
In my mind we talk about the some kind of redesign rather than about
correct change: the original design is based de-facto exactly on using âmagic
numbersâ; configurable measurements units in an explicit form are missing in
the original design. Yes, my solution solves the problem in the code
implementing accordingly to the original design and quite could be realized in
the code implementing original design without waiting for future redesigns and
refactoring, especially with undefined due date.
Thanks,
Dr. Gregory Turovets
"â¦We're all mad here. I'm mad. You're mad."
"How do you know I'm mad?" said Alice.
"You must be," said the Cat, "or you wouldn't have come here."
Alice's Adventures in Wonderland by Lewis
Carroll<http://www.livelib.ru/author/157108>.
From: Jacob Barrett [mailto:notificati...@github.com]
Sent: Thursday, July 06, 2017 17:35
To: apache/geode-native <geode-nat...@noreply.github.com>
Cc: Gregory Turovets <gregory.turov...@amdocs.com>; Mention
<ment...@noreply.github.com>
Subject: Re: [apache/geode-native] GEODE-2891 connect-timeout violation in
C++ Native Client (#106)
@gregt5259<https://github.com/gregt5259> This is a solution to the problem
but not the solution we as committers are comfortable committing as it directly
conflicts with the correct change, which is to use type safe durations rather
than magic number math and system wide properties to create a confusing array
of time values.
If you want this change sooner than later you could implement it using
std::chrono::duration as outlined in GEODE-3137 or maintain a fork with your
change in it.
â
You are receiving this because you were mentioned.
Reply to this email directly, view it on
GitHub<https://github.com/apache/geode-native/pull/106#issuecomment-313414625>,
or mute the
thread<https://github.com/notifications/unsubscribe-auth/AbZcfv8z-a_Qfl4VwbQmqK8WI7aM9k9aks5sLPB0gaJpZM4OOTnp>.
This message and the information contained herein is proprietary and
confidential and subject to the Amdocs policy statement,
you may review at https://www.amdocs.com/about/email-disclaimer
<https://www.amdocs.com/about/email-disclaimer>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
