Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/634#discussion_r128082288
--- Diff:
geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java
---
@@ -90,12 +92,17 @@ public synchronized void launchVM(String version, int
vmNum, boolean bouncedVM)
}
// TODO - delete directory contents, preferably with commons io
FileUtils
- Process process = Runtime.getRuntime().exec(cmd, null, workingDir);
- pendingVMs++;
- ProcessHolder holder = new ProcessHolder(process);
- processes.put(vmNum, holder);
- linkStreams(version, vmNum, holder, process.getErrorStream(),
System.err);
- linkStreams(version, vmNum, holder, process.getInputStream(),
System.out);
+ try {
+ Process process = Runtime.getRuntime().exec(cmd, null, workingDir);
+ pendingVMs++;
+ ProcessHolder holder = new ProcessHolder(process);
+ processes.put(vmNum, holder);
+ linkStreams(version, vmNum, holder, process.getErrorStream(),
System.err);
+ linkStreams(version, vmNum, holder, process.getInputStream(),
System.out);
+ } catch (RuntimeException | Error t) {
+ t.printStackTrace();
+ throw t;
+ }
--- End diff --
Worth logging a message telling us where it is printed from with the stack
trace?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
