GitHub user galen-pivotal opened a pull request: https://github.com/apache/geode/pull/649
GEODE-2997: Change new protocol GetAllResponse. @kohlmu-pivotal @hiteshk25 @WireBaron @pivotal-amurmann @bschuchardt I think it's better to return the errors and the successful keys so that one failed lookup doesn't mess up the whole request. Imagining this as a conversational PR to see what the response is. Signed-off-by: Galen O'Sullivan <gosulli...@pivotal.io> Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [X] Is your initial contribution a single, squashed commit? - [NO.] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/galen-pivotal/geode changeGetAllAPI Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/649.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #649 ---- commit 2b07dfc3cae729b8e23655fa11f3e8d485c520c4 Author: Alexander Murmann <amurm...@pivotal.io> Date: 2017-07-20T21:44:16Z GEODE-2997: Change new protocol GetAllResponse. I think it's better to return the errors and the successful keys so that one failed lookup doesn't mess up the whole request. Imagining this as a conversational PR to see what the response is. Signed-off-by: Galen O'Sullivan <gosulli...@pivotal.io> ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---