Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/643#discussion_r129649690
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
---
@@ -53,10 +52,10 @@
ProtobufUtilities.createEncodedValue(serializationService,
resultValue);
return
Success.of(RegionAPI.GetResponse.newBuilder().setResult(encodedValue).build());
} catch (UnsupportedEncodingTypeException ex) {
- return Failure.of(
- ClientProtocol.ErrorResponse.newBuilder().setMessage("Encoding
not supported.").build());
+ return Failure
--- End diff --
We're not entirely consistent with when we log errors and when we don't.
Probably these should be logged like the others?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
