Github user boglesby commented on a diff in the pull request:

    https://github.com/apache/geode/pull/570#discussion_r130937683
  
    --- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionDataStore.java
 ---
    @@ -494,6 +494,18 @@ CreateBucketResult grabFreeBucket(final int 
possiblyFreeBucketId, final Distribu
     
           return result;
     
    +    } catch (RuntimeException validationException) {
    +      // GEODE-3055
    +      PartitionedRegion leader = 
ColocationHelper.getLeaderRegion(this.partitionedRegion);
    +      boolean isLeader = leader.equals(this.partitionedRegion);
    --- End diff --
    
    What if there is more than one colocated child region and one of the child 
buckets is successfully created, but the other is not. This code will remove 
the parent bucket. Will the one that was successfully created also get removed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to