> On Aug. 2, 2017, 4:44 p.m., Kirk Lund wrote: > > You might consider hoisting these classes out of management pkg and into > > org.apache.geode.test.something. Maybe even move them to geode-test module. > > They seem very useful even outside of geode-core and management. > > > > Ship It!
Great suggestion, this also lets me separate the test utilities from the tests that test the test utilities. (That was a tongue twister..) - Jared ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61166/#review181999 ----------------------------------------------------------- On Aug. 2, 2017, 5:54 p.m., Jared Stewart wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61166/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2017, 5:54 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > ------- > > GEODE-3313: Test utility supports building jar files with multiple classes > > > Diffs > ----- > > geode-junit/build.gradle e47095f > > geode-junit/src/main/java/org/apache/geode/test/compiler/ClassNameExtractor.java > PRE-CREATION > > geode-junit/src/main/java/org/apache/geode/test/compiler/CompiledSourceCode.java > PRE-CREATION > geode-junit/src/main/java/org/apache/geode/test/compiler/JarBuilder.java > PRE-CREATION > geode-junit/src/main/java/org/apache/geode/test/compiler/JavaCompiler.java > PRE-CREATION > > geode-junit/src/main/java/org/apache/geode/test/compiler/UncompiledSourceCode.java > PRE-CREATION > > geode-junit/src/test/java/org/apache/geode/test/compiler/ClassNameExtractorTest.java > PRE-CREATION > > geode-junit/src/test/java/org/apache/geode/test/compiler/JarBuilderTest.java > PRE-CREATION > > geode-junit/src/test/java/org/apache/geode/test/compiler/JavaCompilerTest.java > PRE-CREATION > > geode-junit/src/test/java/org/apache/geode/test/compiler/UncompiledSourceCodeTest.java > PRE-CREATION > > geode-junit/src/test/resources/org/apache/geode/test/compiler/AbstractExtendsFunctionAdapter.java > PRE-CREATION > > geode-junit/src/test/resources/org/apache/geode/test/compiler/AbstractFunction.java > PRE-CREATION > > geode-junit/src/test/resources/org/apache/geode/test/compiler/ConcreteExtendsAbstractExtendsFunctionAdapter.java > PRE-CREATION > > geode-junit/src/test/resources/org/apache/geode/test/compiler/ExtendsAbstractFunction.java > PRE-CREATION > > geode-junit/src/test/resources/org/apache/geode/test/compiler/ExtendsFunctionAdapter.java > PRE-CREATION > > geode-junit/src/test/resources/org/apache/geode/test/compiler/ImplementsFunction.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/61166/diff/7/ > > > Testing > ------- > > Precheckin running > > > Thanks, > > Jared Stewart > >
