Github user jhuynh1 commented on a diff in the pull request:

    https://github.com/apache/geode/pull/609#discussion_r130952081
  
    --- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunction.java
 ---
    @@ -85,8 +72,10 @@ public void execute(FunctionContext context) {
           }
     
         } else {
    -      throw new IllegalArgumentException(
    +      IllegalStateException illegalStateException = new 
IllegalStateException(
               "The AEQ does not exist for the index " + indexName + " region " 
+ region.getFullPath());
    +      logger.error(illegalStateException.getMessage());
    --- End diff --
    
    I still think we should just throw the exception here.  The executing side 
will either get a true or false anyways and the exception never actually gets 
propagated to the user.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to