Github user PurelyApplied commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132307061
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java ---
@@ -157,7 +162,7 @@ protected static Properties loadGemFireProperties(final
URL url) {
if (url != null) {
try {
properties.load(new FileReader(new File(url.toURI())));
- } catch (Exception e) {
+ } catch (Exception ignored) {
--- End diff --
Are we really ignoring the exception if we're doing something in response
to it?
Ditto lines 272, 438.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
