----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61722/#review183187 -----------------------------------------------------------
Ship it! Ship It! - Nick Reich On Aug. 17, 2017, 11:20 p.m., anilkumar gingade wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61722/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2017, 11:20 p.m.) > > > Review request for geode, Darrel Schneider, Eric Shu, Lynn Gallinat, and Nick > Reich. > > > Repository: geode > > > Description > ------- > > While creating bucket region, to satisfy the redudndancy copies the bucket > regions > are created on all vailable nodes. The initialization (setting persistentIDs) > of > these buckets are done after creating buckets on all the nodes. This > introduced > a race condition for the bucket region which are recovered from the disk to > exchange thier old id with the peer node resulting in > ConflictingPersistentData > Exception. > > The changes are done so that the regions persistent ids are set as soon as > they > are created/initialized. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/cache/BucketPersistenceAdvisor.java > 367bb75e9 > > geode-core/src/test/java/org/apache/geode/internal/cache/BucketPersistenceAdvisorTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/61722/diff/1/ > > > Testing > ------- > > added new unit test. > run PartitionedRegionSingleHopDUnitTest.testClientMetadataForPersistentPrs > 1400 times > > > Thanks, > > anilkumar gingade > >
