----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62506/#review186003 -----------------------------------------------------------
geode-core/src/test/java/org/apache/geode/internal/cache/ClientServerTransactionDUnitTest.java Lines 4109 (patched) <https://reviews.apache.org/r/62506/#comment262355> This is actually "doTransactionOnServer", as there is nothing about the method which is tied to server1. geode-core/src/test/java/org/apache/geode/internal/cache/ClientServerTransactionDUnitTest.java Lines 4114 (patched) <https://reviews.apache.org/r/62506/#comment262351> Avoid single character variable names geode-core/src/test/java/org/apache/geode/internal/cache/ClientServerTransactionDUnitTest.java Lines 4120 (patched) <https://reviews.apache.org/r/62506/#comment262354> Can this have a generic type like above method? Would remove casting to Integer below. geode-core/src/test/java/org/apache/geode/internal/cache/ClientServerTransactionDUnitTest.java Lines 4125 (patched) <https://reviews.apache.org/r/62506/#comment262353> Do not need to hold onto the set: for (Object key : region.keySet()) - Nick Reich On Sept. 22, 2017, 5:01 p.m., Eric Shu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62506/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2017, 5:01 p.m.) > > > Review request for geode, anilkumar gingade, Darrel Schneider, Kirk Lund, > Lynn Gallinat, and Nick Reich. > > > Bugs: GEODE-3679 > https://issues.apache.org/jira/browse/GEODE-3679 > > > Repository: geode > > > Description > ------- > > Sets the originating member id from client transaction in partition message > when a server needs to perform operaton and send to other peers. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PartitionMessage.java > 8c27107 > > geode-core/src/test/java/org/apache/geode/internal/cache/ClientServerTransactionDUnitTest.java > 96b89b9 > > > Diff: https://reviews.apache.org/r/62506/diff/1/ > > > Testing > ------- > > precheckin. > > > Thanks, > > Eric Shu > >
