+1 On Thu, Aug 8, 2019 at 7:02 PM John Blum <jb...@pivotal.io> wrote:
> +1 for Kirk's changes in 1.10. This will be critical for SD Neuman and > SBDG 1.3. > > On Thu, Aug 8, 2019 at 10:57 AM Owen Nichols <onich...@pivotal.io> wrote: > > > Hi Kirk and Mark, thank you for bringing your concern. > > > > Our “critical fixes” rule allows critical fixes to be brought to the > > release branch by proposal on the dev list, as you have just done. If > > there is consensus from the Geode community that this NPE fix satisfies > the > > “critical fixes” rule, Dick or I will be happy to bring it to the 1.10.0 > > release branch. > > > > -Owen > > > > > On Aug 8, 2019, at 10:54 AM, Kirk Lund <kl...@apache.org> wrote: > > > > > > I'd like to propose including the fix for GEODE-6959 in 1.10.0. > > > > > > Spring Boot users are very likely to hit this NPE during > forceDisconnect. > > > > > > If a custom log4j2.xml is used without specifying the Geode > > AlertAppender, > > > GMSMembershipManager may throw a NullPointerException when invoking > > > AlertAppender.getInstance().stopSession() during a forceDisconnect. > This > > > change prevents the NullPointerException allowing forceDisconnect to > > finish. > > > Tests are included with this fix. > > > > > > PR: https://github.com/apache/geode/pull/3899 > > > GEODE-6959: NPE if AlertAppender is not defined > > > > > > Thanks, > > > Kirk and Mark > > > > > > -- > -John > john.blum10101 (skype) > -- Juan José Ramos Cassella Senior Technical Support Engineer Email: jra...@pivotal.io Office#: +353 21 4238611 Mobile#: +353 87 2074066 After Hours Contact#: +1 877 477 2269 Office Hours: Mon - Thu 08:30 - 17:00 GMT. Fri 08:30 - 16:00 GMT How to upload artifacts: https://support.pivotal.io/hc/en-us/articles/204369073 How to escalate a ticket: https://support.pivotal.io/hc/en-us/articles/203809556 [image: support] <https://support.pivotal.io/> [image: twitter] <https://twitter.com/pivotal> [image: linkedin] <https://www.linkedin.com/company/3048967> [image: facebook] <https://www.facebook.com/pivotalsoftware> [image: google plus] <https://plus.google.com/+Pivotal> [image: youtube] <https://www.youtube.com/playlist?list=PLAdzTan_eSPScpj2J50ErtzR9ANSzv3kl>
