Hi Kirk, The test does not fail. When you run the test (testSerializable) it creates a list of serializable classes and puts it in the actualSerializables.dat file and them compares if all the classes listed are present in the sanctioned-geode-core-serializables.txt. If we did not change any serializabale classes then these two files remain the same. However now in this release, there are classes in sanctioned-geode-core-serializables.txt which are not present in actualSerializables.dat.
I wanted to know why are those classes are not listed in actualSerializables.dat and if you remove them from sanctioned-geode-core-serializables.txt testSerializables passes but testSanctionedClassesExistAndDoDeserialize fails. Regards Naba On Thu, Sep 5, 2019 at 3:21 PM Kirk Lund <kl...@apache.org> wrote: > Hi Naba, > > I failed to reproduce the problem you reported on Mac OS, and our pipeline > didn't fail this test. What OS are you running integrationTest on? Here's > the steps I followed: > > 1) checkout tag rel/v1.10.0.RC1 > > $ git checkout tags/rel/v1.10.0.RC1 > > 2) clean, then build with unit tests > > $ ./gradlew clean > $ ./gradlew build > > 3) run AnalyzeSerializablesJUnitTest > > $ ./gradlew geode-core:integrationTest --tests > AnalyzeSerializablesJUnitTest > > The test passes for me and there are no modified files in the repo after > running the test. Did the test actually fail for you? If so, please share > the call stack. If it is still failing for you I recommend getting a fresh > clone of geode and then repeat the above steps. > > Thanks, > Kirk > > On Thu, Sep 5, 2019 at 10:16 AM Nabarun Nag <n...@apache.org> wrote: > > > Hello, > > > > I was able to notice that after running the testSerializable JUnit test, > > the generated actualSerializables.dat and the > > sanctioned-geode-core-serializables.txt do not match. There are certain > > classes mentioned in sanctioned-geode-core-serializables.txt that are not > > present in actualSerializables.dat file > > > > - EvictionAttributes > > - ExpirationAttributes > > - MembershipAttributes > > - SubscriptionAttributes > > - EvictionAttributesImpl > > - PartitionAttributesImpl > > - CacheRealizaitonFunction > > > > > > But removing them causes testSanctionedClassesExistAndDoDeserialize() > test > > to fail. > > > > I am not sure if this is harmless or has some adverse consequences. I > would > > like to know why it's designed this way. > > > > Regards > > Nabarun Nag > > > > > > > > On Wed, Sep 4, 2019 at 4:14 PM Dick Cavender <dcaven...@pivotal.io> > wrote: > > > > > We manually signed the apache-geode-1.10.0-src.tgz dist and uploaded > the > > > asc file. > > > > > > Unclear on why this is no longer automatically generated as part of the > > > build step as 1.9.1 it was generated correctly. We have worked around > it > > in > > > the prepare_rc.sh adding a check for it going forward and generating it > > if > > > missing. > > > > > > > > > On Wed, Sep 4, 2019 at 3:32 PM Dan Smith <dsm...@pivotal.io> wrote: > > > > > > > I don't see a .asc signature file for apache-geode-1.10.0-src.tgz. > Did > > we > > > > miss that signature file somehow? > > > > > > > > -Dan > > > > > > > > On Wed, Sep 4, 2019 at 9:33 AM Dick Cavender <dcaven...@pivotal.io> > > > wrote: > > > > > > > > > The apache-geode-native-1.10.0-src.tar.gz dist has been fixed in > RC1 > > > and > > > > > can be found at: > > > > https://dist.apache.org/repos/dist/dev/geode/1.10.0.RC1/ > > > > > Please continue to review RC1 as a viable 1.10 RC. The voting > > deadline > > > > > remains 3PM PST Thursday Sept 5th. > > > > > > > > > > -Dick > > > > > > > > > > > > > > > On Tue, Sep 3, 2019 at 3:09 PM Dan Smith <dsm...@pivotal.io> > wrote: > > > > > > > > > > > Everything but the missing native source looks good. If we can > fix > > > > that, > > > > > > I'll +1 this RC. > > > > > > > > > > > > -Dan > > > > > > > > > > > > On Tue, Sep 3, 2019 at 2:26 PM Dan Smith <dsm...@pivotal.io> > > wrote: > > > > > > > > > > > > > -1 It looks like this RC is also missing the native source, > just > > > like > > > > > > > 1.9.1.RC3. The tar file is there, but it is empty. > > > > > > > > > > > > > > -Dan > > > > > > > > > > > > > > On Fri, Aug 30, 2019 at 2:06 PM Dick Cavender < > > > dcaven...@pivotal.io> > > > > > > > wrote: > > > > > > > > > > > > > >> Hello Geode dev community, > > > > > > >> > > > > > > >> This is a release candidate for Apache Geode, version > > 1.10.0.RC1. > > > > > > >> Thanks to all the community members for their contributions to > > > this > > > > > > >> release! > > > > > > >> > > > > > > >> Please do a review and give your feedback. The deadline is 3PM > > PST > > > > > > >> Thursday > > > > > > >> Sept 5th. > > > > > > >> Release notes can be found at: > > > > > > >> > > > > > > >> > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.10.0 > > > > > > >> > > > > > > >> Please note that we are voting upon the source tags: > > > rel/v1.10.0.RC1 > > > > > > >> > > > > > > >> Apache Geode: > > > > > > >> https://github.com/apache/geode/tree/rel/v1.10.0.RC1 > > > > > > >> Apache Geode examples: > > > > > > >> https://github.com/apache/geode-examples/tree/rel/v1.10.0.RC1 > > > > > > >> Apache Geode native: > > > > > > >> https://github.com/apache/geode-native/tree/rel/v1.10.0.RC1 > > > > > > >> > > > > > > >> Source and binary files: > > > > > > >> https://dist.apache.org/repos/dist/dev/geode/1.10.0.RC1/ > > > > > > >> > > > > > > >> Maven staging repo: > > > > > > >> > > > > > > > https://repository.apache.org/content/repositories/orgapachegeode-1058 > > > > > > >> > > > > > > >> Geode's KEYS file containing PGP keys we use to sign the > > release: > > > > > > >> https://github.com/apache/geode/blob/develop/KEYS > > > > > > >> > > > > > > >> PS: Command to run geode-examples: ./gradlew > -PgeodeReleaseUrl= > > > > > > >> https://dist.apache.org/repos/dist/dev/geode/1.10.0.RC1 > > > > > > >> -PgeodeRepositoryUrl= > > > > > > >> > > > > > > > https://repository.apache.org/content/repositories/orgapachegeode-1058 > > > > > > >> build runAll > > > > > > >> > > > > > > >> Regards > > > > > > >> Dick Cavender > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > >
