+1 On Wed, Jan 8, 2020 at 1:56 PM Jason Huynh <jhu...@pivotal.io> wrote:
> +1 > > On Wed, Jan 8, 2020 at 1:21 PM Dan Smith <dsm...@pivotal.io> wrote: > > > +1. Looks good! > > > > -Dan > > > > On Wed, Jan 8, 2020 at 12:56 PM Blake Bender <bben...@pivotal.io> wrote: > > > > > +1 - this is also a todo item for the native client, I think. NC has a > > bug > > > in logging which is in my top 3 for "most irritating," as well, which > is > > > that logging actually starts *before* the logging system is > initialized, > > so > > > even if you *do* configure a log file, if something happens in NC prior > > to > > > that it gets logged to stdout. Similarly, logging can continue in NC > > > *after* the logger is shut down, and any logging after that also goes > to > > > stdout. I'm a big fan of making everything consistent, and this seems > as > > > good a way as any. > > > > > > Just FWIW, using the character '-' anywhere in a log file name for NC > > will > > > currently cause a segfault, so this will force us to fix that problem > as > > > well. > > > > > > > > > On Wed, Jan 8, 2020 at 12:39 PM Jacob Barrett <jbarr...@pivotal.io> > > wrote: > > > > > > > Please see RFC for Logging to Standard Out. > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/GEODE/Logging+to+Standard+Out > > > > < > > > > > > https://cwiki.apache.org/confluence/display/GEODE/Logging+to+Standard+Out > > > > > > > > > > > > > Please comment by 1/21/2020. > > > > > > > > Thanks, > > > > Jake > > > > > > > > > > > > > >
