Looks good. I put a few comments inline (look for the yellow highlights). -Dan
On Mon, Mar 30, 2020 at 2:21 PM Kirk Lund <kl...@apache.org> wrote: > [I added this as a comment on the wiki page] > > You might want to consider making RestoreRedundancyOperation actually > extend CompletableFuture. The interface is already very similar to Future, > and if you extend CompletableFuture, then the user of the API can easily > combine it with other CompletableFutures. It also helps push us in a > direction of standardizing on Future/CompletableFuture for APIs that > involve asynchronous computation. > > On Mon, Mar 30, 2020 at 11:47 AM Donal Evans <doev...@pivotal.io> wrote: > > > Hey everyone, > > > > An RFC for adding gfsh commands to allow users to restore redundancy to > > partitioned regions and to easily check the redundancy status of > > partitioned regions has been posted: > > > https://cwiki.apache.org/confluence/display/GEODE/Redundancy+Gfsh+Commands > > . > > > > Please review and comment on this RFC by Monday, 04/06/2020. > > > > Please also note that this RFC has been revised from an earlier draft > > version that some of you may have seen, so the content may have changed. > > > > Thanks, > > Donal > > >
