For context, here is an example of PR that added warnings as error
https://github.com/apache/geode/pull/4816. Here is the JIRA
https://issues.apache.org/jira/projects/GEODE/issues/GEODE-7869
-michael
On Fri, May 8, 2020 at 11:45 AM Kirk Lund <kl...@apache.org> wrote:
> I'm reviewing lots of PRs which are
> adding @SuppressWarnings("deprecation"), etc. I think this is a bad trend.
> We should not be suppressing warnings in our code. That's hiding a problem
> that we'll need to or want to deal with in the future. Also, if you add
> several of these suppress annotations into a class or a method or a test,
> it really diminishes the readability. It adds noise and suppresses valid
> warnings.
>
> On one of Jinmei's PRs, she responded saying she has to add these to her
> code because of some change that Jake made to the build. Can we make it so
> we don't have to add these suppressions?
>
> Thanks,
> Kirk
>
