Thanks Alberto for the detailed list. I think I was able to find explanations for all, see below.
> https://github.com/apache/geode/pull/6177 # geode-core/src/main/java/org/apache/geode/cache/client/internal/QueueManagerImpl.java #matches your rule: # geode-core/**/org/apache/geode/cache/client/** #however, support branch PR should not have triggered CODEWATCHERS, I will fix. > https://github.com/apache/geode/pull/6156 # geode-core/src/distributedTest/java/org/apache/geode/cache/client/internal/CacheServerSSLConnMaxThreadsDUnitTest.java #matches your rule: # geode-core/**/org/apache/geode/cache/client/** > https://github.com/apache/geode/pull/6153 # geode-wan/build.gradle #matches your rule: # geode-wan/** #note that in CODEOWNERS, this would not have matched, because gradle files are remapped by a later rule > https://github.com/apache/geode/pull/6151 # geode-core/src/main/java/org/apache/geode/cache/client/internal/QueueManagerImpl.java #matches your rule: # geode-core/**/org/apache/geode/cache/client/** > https://github.com/apache/geode/pull/6075 # geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java #matches your rule: # geode-core/**/org/apache/geode/internal/cache/tier/** > https://github.com/apache/geode/pull/6116 #you are listed as a reviewer because you approved this PR. You were never requested via CODEWATCHERS. ________________________________ From: Owen Nichols <onich...@vmware.com> Sent: Wednesday, March 24, 2021 2:30 AM To: dev@geode.apache.org <dev@geode.apache.org> Subject: Re: CODEWATCHERS file effects Hi Alberto, is there a specific PR you feel you were added to in error? I spot-checked #6179 and there was one test change in geode-wan so that one seems correct. I am looking for a solution to avoid adding watchers to draft PRs until they are taken out of draft mode, but it's non-trivial so I don't have an ETA yet. On 3/23/21, 12:08 PM, "Alberto Gomez" <alberto.go...@est.tech> wrote: Hi, I have recently added myself to the CODEWATCHERS file to be assigned as reviewer to PRs touching certain areas of the code but seems that I am being added to many more PRs that what I intended, even to Draft PRs. Is anybody else experiencing the same? Thanks, Alberto
