Comments inline… Please keep your PR in draft mode anytime it is not ready to be reviewed.
This includes if you have received request for changes, or if any PR checks are not passing. How do I know if everyone is done reviewing? Or even who might be reviewing? Different reviewers may be looking at different areas, depending on the scope of the change. If the PR suddenly switches back to ‘Draft` what does that mean if I’m reviewing it? Worse still, if I’m the owner and someone else switches it to Draft I’m not notified. Additionally, many PR checks fail for reasons unrelated to the PR so switching blindly to ‘Draft’ seems pointless. If you’re reviewing someone’s PR, and notice any checks not passing or you are requesting changes, please also click “Convert to draft”. I really don’t agree with this – if you have an issue with a PR for whatever reason, please respect the author and address it directly with them. I certainly feel uncomfortable ‘messing’ with someone else’s PR and, by the same token, don’t want my PRs adjusted without my input. --Jens
