+1 In the case where someone isn’t sure who might be good to request a review from, GitHub seems to now have a reviewer-recommendation feature based on who has recently touched the files in the PR. Non-committers can always email the dev list if help is needed.
From: Patrick Johnson <jpatr...@vmware.com.INVALID> Date: Wednesday, June 29, 2022 at 9:45 AM To: dev@geode.apache.org <dev@geode.apache.org> Subject: Re: CODEOWNERS? (was Re: Pending PR reviews) ⚠ External Email +1 for getting rid of CODEOWNERS. > On Jun 29, 2022, at 9:33 AM, Anthony Baker <bak...@vmware.com.INVALID> wrote: > > ⚠ External Email > > I realize that this is a thread hijack, but hopefully a useful one. I’ve seen > several requests for timely reviews in recent months. I think that the > CODEOWNERS goals were important and laudable—directing review requests to > those most suited to provide oversight—but the implementation has been > problematic. The size, complexity, and interconnectedness of the code base > meant that many pull requests tagged not just one expert but just about EVERY > expert in the community. This is rather inefficient, to say the least. > > I propose that we revert CODEOWNERS and return to the review-then-commit > model requiring at least one +1 vote from a committer. I see Owen has already > created a PR [1] for this change. > > Thoughts? > > Anthony > > [1] > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F7820&data=05%7C01%7Conichols%40vmware.com%7Cb5a2c412552c4149154f08da59eed142%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637921179501621811%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=uqMJrZPsXE7GcJK2EwEEiul%2FhGCPLmyfUKC2x%2FhiStU%3D&reserved=0 > > >> On Jun 28, 2022, at 5:43 AM, Mario Ivanac <mario.iva...@est.tech> wrote: >> >> ⚠ External Email >> >> Hi, >> >> The following PRs: >> >> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F7323&data=05%7C01%7Conichols%40vmware.com%7Cb5a2c412552c4149154f08da59eed142%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637921179501778038%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Aqjmm0EybFdmNlmC37nHgmCT50f%2B3NFcpOrtLEXBFwo%3D&reserved=0 >> >> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F7749&data=05%7C01%7Conichols%40vmware.com%7Cb5a2c412552c4149154f08da59eed142%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637921179501778038%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=1hlNbZin%2Btdw3cBr484dIRPRCmoYaVBbKRYcoiKLs1U%3D&reserved=0 >> >> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fgeode%2Fpull%2F7664&data=05%7C01%7Conichols%40vmware.com%7Cb5a2c412552c4149154f08da59eed142%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637921179501778038%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ouqA09rGyTcgandMR2sS7%2BK901NO0tBAYR32aaAl5uI%3D&reserved=0 >> >> are waiting for review for some time. >> >> >> Could code owners review these PRs? >> >> Thanks, >> Mario >> >> ________________________________ >> >> ⚠ External Email: This email originated from outside of the organization. Do >> not click links or open attachments unless you recognize the sender. >
