Definitely branch from develop - master shouldn't get touched until we release.
I think creating a JIRA for the feature request and mentioning it in the branch name is a good practice. -Dan On Tue, May 26, 2015 at 2:51 PM, Neil Stevenson < [email protected]> wrote: > Hi, > I have a patch ready to ship for Geode, two amended files and two unit > tests > > Although the instructions are a little unclear, I'm assuming we branch > from "develop". Not "master" I hope. > > If so, how should I name my branch ? Do we need a feature request first ? > > Eg. is the branch "feature/GEODE-123" matching against a Jira > > > The patch itself is fairly small, reinstating ".gfsh2rc" init file > handling in $GEODE/bin/gfsh > that disappeared in the transition from GF 6.6 to 7.0 > > Obviously this will need amendment once the "gfsh" naming issue concludes. > > Neil >
