Hi Dan, Unit testing is super important for open source projects, so I'm glad some high quality testing is coming in to the project!
Along with Roman's comment, it will be nice those tests ; 1. are unit level test where mocks are appropriately used and no running instances are required. (IMO, unit test should be lightweight, and more heavy integration tests should be done separately) 2. completes up to 30mins so that contributors can get a quicker feedback. (we are hoping to get hundreds of contributors so be aware of this! :) ) As Roman suggested, should the unit test of GEODE-6 have basic acceptance tests (can be subset of the several-hour test set) and the open source CI should only tests the subset coverage? On Mon, Jun 15, 2015 at 10:07 AM, Roman Shaposhnik <[email protected]> wrote: > On Mon, Jun 15, 2015 at 9:42 AM, Dan Smith <[email protected]> wrote: > > Welcome Jun! > > > > I like all of your suggestions! One thing to be aware of regarding the CI > > jobs is that the test time is going to go up a lot once GEODE-6 is > > resolved. We'll be adding several hours of tests. That will make having a > > test patch CI job all that more valuable, but it also affects how much > > resources need to be devoted to that. > > Does it just mean that we'd have to have a 'smoke test' testsuite? > > Thanks, > Roman. > -- -jun
