----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36101/#review90248 -----------------------------------------------------------
Ship it! Ship It! - Dan Smith On July 1, 2015, 6:38 p.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36101/ > ----------------------------------------------------------- > > (Updated July 1, 2015, 6:38 p.m.) > > > Review request for geode and Kirk Lund. > > > Bugs: GEODE-71 > https://issues.apache.org/jira/browse/GEODE-71 > > > Repository: geode > > > Description > ------- > > The javadocs are now correct. > Changed the log message about the host being unknown > to be warn instead of fatal since the whole point of fixing 45348 > was to ignore the unknown host exception > until you try to use the pool for an operation. > I also updated the log message to say: > "Creating pool with unknown host in case > the host becomes known later." > instead of just saying the host was unknown. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/ClientCacheFactory.java > 48bc074da867bf2778b0604e096630d80531496c > > gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/PoolFactory.java > 3f09262147bc2d6d9a62b3161784517df1dfdf29 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/PoolFactoryImpl.java > 7d2a6106e42385eba11f4697166b0b66d14d01a4 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/i18n/LocalizedStrings.java > d5a1f20d8e3a03a0330a560533df8d71776f9851 > > Diff: https://reviews.apache.org/r/36101/diff/ > > > Testing > ------- > > ./gradlew test > > > Thanks, > > Darrel Schneider > >
