----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36416/#review91481 -----------------------------------------------------------
gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionStatsJUnitTest.java (line 265) <https://reviews.apache.org/r/36416/#comment144864> This test uses JUnit 4 syntax (it doesn't extend TestCase) so all test methods require an @Test annotation or nothing will be executed. We may need to beef up checkMissedTests to look for this as well as missing categories. - Kirk Lund On July 11, 2015, 12:26 a.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36416/ > ----------------------------------------------------------- > > (Updated July 11, 2015, 12:26 a.m.) > > > Review request for geode, Darrel Schneider and Hitesh Khamesra. > > > Repository: geode > > > Description > ------- > > For persistent regions, we were correctly updating this stat. But for > non persistent regions we did not read the old size on disk, so we were > not updating the stat. > > If the entry was in the async queue, we only increment the stat once > when the final value is actually written to disk. So we will only > decrement the stat if the oldValue is not pending asynchronous write to > disk. > > I'm still seeing issues with the entryCount. I've tracked this down to > what I think is a problem with tombstones. It appears when we modify an > entry that is a tombstone, we increment the entry count once for the new > value, and once for removing the tombstone. But I'm not sure if that is > the full story. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/BucketRegion.java > b46d897e693b397799533662ddeca6c0438ac49e > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/DiskEntry.java > b67d0f10c63a19307288d5c6f2f9538eb280bfe4 > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionStatsJUnitTest.java > 3711329883e4f7f411c4389872f4ad9426a4122f > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/PartitionedRegionTestHelper.java > 5db33b64444ea08548af1108cf42c8182562ad01 > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/control/RebalanceOperationDUnitTest.java > a80cb9bdcbac800ab39b722a25480a59f81dd1c2 > > Diff: https://reviews.apache.org/r/36416/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
