That's good enough! Thanks, Kirk
On Mon, Jul 13, 2015 at 10:28 AM, Dan Smith <dsm...@pivotal.io> wrote: > > > > On July 13, 2015, 4:30 p.m., Kirk Lund wrote: > > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/control/InternalResourceManager.java, > line 62 > > > < > https://reviews.apache.org/r/36415/diff/1/?file=1008813#file1008813line62> > > > > > > Please make sure that all new system properties are testable. I > can't tell for sure if this one is or not. What I mean by this is that two > different tests running without forking the JUnit JVM should be able to > have two different values. > > This property can be reset by closing the cache and opening the cache. > It's a non-static field on an object owned by GemFireCacheImpl. The > RebalanceOperationDUnitTest does this - it clears the system property in > the tearDown so that it doesn't affect the next test. > > Is that good enough, or would it be better for this property to not be > final? > > > - Dan > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36415/#review91484 > ----------------------------------------------------------- > > > On July 11, 2015, 12:28 a.m., Dan Smith wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/36415/ > > ----------------------------------------------------------- > > > > (Updated July 11, 2015, 12:28 a.m.) > > > > > > Review request for geode, Darrel Schneider and Hitesh Khamesra. > > > > > > Repository: geode > > > > > > Description > > ------- > > > > Allow multiple regions to be rebalanced in parallel, by setting > > gemfire.resource.manager.threads to something greater than 1. > > > > > > Diffs > > ----- > > > > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/control/InternalResourceManager.java > d144aaf0adab2fcfae54c71e6d4e886ee05884d5 > > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/control/RebalanceOperationImpl.java > be4d8247c288dc12b5566ab80ba7571936649c30 > > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/control/RebalanceResultsImpl.java > a74017b512ab6a319b63bd8ee09c6913fd1cd3ce > > > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/control/RebalanceOperationDUnitTest.java > a80cb9bdcbac800ab39b722a25480a59f81dd1c2 > > > > Diff: https://reviews.apache.org/r/36415/diff/ > > > > > > Testing > > ------- > > > > > > Thanks, > > > > Dan Smith > > > > > >
