+1
We need to fail reviews that don’t have unit tests. There is a handy field on the review board for “Testing Done” which should probably used to call out the unit tests for the reviewer to run. -Jake — Jacob Barrett Manager GemFire Advanced Customer Engineering (ACE) Pivotal [email protected] 503-533-3763 For immediate support please contact Pivotal Support at http://support.pivotal.io/ On Mon, Jul 13, 2015 at 10:27 AM, Kirk Lund <[email protected]> wrote: > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36397/#review91485 > ----------------------------------------------------------- > We really need to start requiring a UnitTests for every change, bugfix, and > new code. Can you please think about ways to write UnitTests for this code? > What I mean by this is a JUnit UnitTest that probably uses Mockito or JMock > and executes in less than 1/10th second. If the code can only be tested by > end-to-end tests then we need to break dependencies on outside Collaborators > (so they can be passed in as mocked objects) to enable isolating a single > class for testing purposes. > - Kirk Lund > On July 10, 2015, 8:45 p.m., Ashvin A wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/36397/ >> ----------------------------------------------------------- >> >> (Updated July 10, 2015, 8:45 p.m.) >> >> >> Review request for geode, Amogh Shetkar and Dan Smith. >> >> >> Bugs: GEODE-10 >> https://issues.apache.org/jira/browse/GEODE-10 >> >> >> Repository: geode >> >> >> Description >> ------- >> >> GEODE-10: Refactor HdfsStore api to match spec >> >> * Currently HdfsStore's configuration object is nested and a user needs >> to >> create multiple sub objects to manage the store instance. This is less >> usable >> and gets confusing at times. User also gets exposed to a lot of >> internal >> details. So replacing nested configuration with a flat structure will >> be >> better. >> * Rename members >> >> >> Diffs >> ----- >> >> >> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/HDFSEventQueueAttributes.java >> ef7e863 >> >> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/HDFSEventQueueAttributesFactory.java >> fc09b7a >> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/HDFSStore.java >> f5bd943 >> >> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/HDFSStoreFactory.java >> 516d2aa >> >> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/HDFSStoreMutator.java >> 47b1708 >> >> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSEventQueueAttributesImpl.java >> df89841 >> >> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSIntegrationUtil.java >> 242923b >> >> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSStoreConfigHolder.java >> 50ea3c6 >> >> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSStoreCreation.java >> b5fbfe8 >> >> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSStoreFactoryImpl.java >> e7e75dc >> >> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSStoreImpl.java >> 8e7e358 >> >> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSStoreMutatorImpl.java >> e4e2093 >> >> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/SizeTieredHdfsCompactionConfigHolder.java >> 57d58b7 >> >> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/hoplog/HDFSCompactionManager.java >> d96cd11 >> >> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/hoplog/HDFSUnsortedHoplogOrganizer.java >> c9be401 >> >> gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/internal/hoplog/HdfsSortedOplogOrganizer.java >> 7bb025b >> >> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java >> 76488dd >> >> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/CacheCreation.java >> a5fd3f1 >> >> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/CacheXmlParser.java >> e015624 >> >> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/HDFSStoreCommands.java >> b044156 >> >> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/AlterHDFSStoreFunction.java >> 13ba5fa >> >> gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/cli/functions/CreateHDFSStoreFunction.java >> ac9c895 >> >> gemfire-core/src/test/java/com/gemstone/gemfire/cache/hdfs/internal/ColocatedRegionWithHDFSDUnitTest.java >> ea9dc11 >> >> gemfire-core/src/test/java/com/gemstone/gemfire/cache/hdfs/internal/HDFSConfigJUnitTest.java >> dc3f404 >> >> gemfire-core/src/test/java/com/gemstone/gemfire/cache/hdfs/internal/HdfsStoreMutatorJUnitTest.java >> f12078e >> >> gemfire-core/src/test/java/com/gemstone/gemfire/cache/hdfs/internal/hoplog/BaseHoplogTestCase.java >> 06c3c4b >> >> gemfire-core/src/test/java/com/gemstone/gemfire/cache/hdfs/internal/hoplog/HDFSCacheLoaderJUnitTest.java >> 3e4b8e2 >> >> gemfire-core/src/test/java/com/gemstone/gemfire/cache/hdfs/internal/hoplog/HDFSCompactionManagerJUnitTest.java >> 2c32d61 >> >> gemfire-core/src/test/java/com/gemstone/gemfire/cache/hdfs/internal/hoplog/HDFSUnsortedHoplogOrganizerJUnitTest.java >> 8d2fae3 >> >> gemfire-core/src/test/java/com/gemstone/gemfire/cache/hdfs/internal/hoplog/HdfsSortedOplogOrganizerJUnitTest.java >> 0884a40 >> >> gemfire-core/src/test/java/com/gemstone/gemfire/cache/hdfs/internal/hoplog/TieredCompactionJUnitTest.java >> 007e73b >> >> gemfire-core/src/test/java/com/gemstone/gemfire/cache/hdfs/internal/hoplog/mapreduce/HoplogUtilJUnitTest.java >> 576144f >> >> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/HDFSRegionOperationsJUnitTest.java >> d068cb4 >> >> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/HDFSStoreCommandsJUnitTest.java >> b46abc7 >> >> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/functions/AlterHDFSStoreFunctionJUnitTest.java >> f66f54b >> >> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/functions/CreateHDFSStoreFunctionJUnitTest.java >> a20297b >> >> gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/functions/DescribeHDFSStoreFunctionJUnitTest.java >> fe630fe >> >> Diff: https://reviews.apache.org/r/36397/diff/ >> >> >> Testing >> ------- >> >> >> Thanks, >> >> Ashvin A >> >>
