> On July 29, 2015, 12:47 a.m., William Markito wrote: > > Why some tests are using System.out.println and some uses LogWriter ? Since > > it looks like you did a nice refactoring around that I'm just asking if we > > could have some consensus around what should be used within our tests as a > > standard.
Since we're talking about speeding up our tests we could for instance use an async appender for all our testing output if it's all log4j for example. But this may actually be a separate JIRA and not block this patch. - William ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36866/#review93375 ----------------------------------------------------------- On July 28, 2015, 9:27 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36866/ > ----------------------------------------------------------- > > (Updated July 28, 2015, 9:27 p.m.) > > > Review request for geode, Darrel Schneider, John Blum, and William Markito. > > > Bugs: GEODE-127 > https://issues.apache.org/jira/browse/GEODE-127 > > > Repository: geode > > > Description > ------- > > Recategorize some tests as IntegrationTests. Specifically the tests involving > spawned processes and file system I/O are now IntegrationTests. > > Improve reliability and screamline test execution time. Fix up JUnit 4 syntax > and misc tidying of test code. > > Add two new TestSuite classes for targeted testing. > > > Diffs > ----- > > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherRemoteJUnitTest.java > fb0df63 > > gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/ExecutableProcess.java > PRE-CREATION > > gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailOutputTestCase.java > a3995f8 > > gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithErrorInOutputJUnitTest.java > b3ca93e > > gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithExtraLineInOutputJUnitTest.java > 1c49749 > > gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithLineMissingFromEndOfOutputJUnitTest.java > 877f671 > > gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithLineMissingFromMiddleOfOutputJUnitTest.java > 629eb7f > > gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithLoggerErrorInOutputJUnitTest.java > b485ba4 > > gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithLoggerFatalInOutputJUnitTest.java > a71ce18 > > gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithLoggerWarnInOutputJUnitTest.java > 211008a > > gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithProblemInOutputTestCase.java > 5e1552f > > gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithSevereInOutputJUnitTest.java > 9089545 > > gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithTimeoutOfWaitForOutputToMatchJUnitTest.java > 2417f3d > > gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/FailWithWarningInOutputJUnitTest.java > 89cc7dc > > gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/GoldenComparator.java > 34c1ce7 > > gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/GoldenStringComparator.java > 75a3398 > > gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/GoldenTestCase.java > 37b4e48 > > gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/GoldenTestFrameworkTestSuite.java > PRE-CREATION > > gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/PassJUnitTest.java > 886fc94 > > gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/PassWithExpectedErrorJUnitTest.java > 39267e9 > > gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/PassWithExpectedProblemTestCase.java > 2958007 > > gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/PassWithExpectedSevereJUnitTest.java > 659e807 > > gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/PassWithExpectedWarningJUnitTest.java > 866e8b2 > > gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/RegexGoldenComparator.java > bc80b3a > > gemfire-core/src/test/java/com/gemstone/gemfire/test/golden/StringGoldenComparator.java > 5547a9e > > gemfire-core/src/test/java/com/gemstone/gemfire/test/process/ProcessTestFrameworkTestSuite.java > PRE-CREATION > > gemfire-core/src/test/java/com/gemstone/gemfire/test/process/ProcessWrapper.java > 3931b22 > > gemfire-core/src/test/java/com/gemstone/gemfire/test/process/ProcessWrapperJUnitTest.java > 7c08fcc > > gemfire-core/src/test/resources/com/gemstone/gemfire/test/golden/log4j2-test.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/36866/diff/ > > > Testing > ------- > > test, integrationTest and targeted testing of TestSuites > > > Thanks, > > Kirk Lund > >
