----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36936/#review93739 -----------------------------------------------------------
gemfire-core/src/test/java/com/gemstone/gemfire/disttx/DistTXDebugDUnitTest.java (line 65) <https://reviews.apache.org/r/36936/#comment148145> It is not clear to me why: 1. you are closing the cache. Can you add a comment? 2. why you are only doing it in the controller jvm. Wouldn't it also be needed in the invokeInEveryVM? It looks like the test has special create code for each jvm. - Darrel Schneider On July 30, 2015, 6:54 p.m., vivek bhaskar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36936/ > ----------------------------------------------------------- > > (Updated July 30, 2015, 6:54 p.m.) > > > Review request for geode and Shirish Deshmukh. > > > Bugs: GEODE-172 > https://issues.apache.org/jira/browse/GEODE-172 > > > Repository: geode > > > Description > ------- > > Fixing an intermittent failure as reported by closing cache after each > individual test. > > Also taking care to avoid an assertion failure that is reflected in GEODE-110 > and GEODE-141. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/TXRegionState.java > bb6ae5f > > gemfire-core/src/test/java/com/gemstone/gemfire/disttx/DistTXDebugDUnitTest.java > ff0a506 > > gemfire-core/src/test/java/com/gemstone/gemfire/disttx/DistributedTransactionDUnitTest.java > 2522e63 > > Diff: https://reviews.apache.org/r/36936/diff/ > > > Testing > ------- > > ./gradlew gemfire-core:integrationTest -DintegrationTest.single=*DistTX*JUnit* > ./gradlew -DdistributedTest.single=DistTXDistributedTestSuite > gemfire-core:distributedTest > > > Thanks, > > vivek bhaskar > >
