----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37193/#review94439 -----------------------------------------------------------
Ship it! Ship It! - Kirk Lund On Aug. 6, 2015, 5:47 p.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37193/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2015, 5:47 p.m.) > > > Review request for geode and Kirk Lund. > > > Bugs: GEODE-190 > https://issues.apache.org/jira/browse/GEODE-190 > > > Repository: geode > > > Description > ------- > > A weak map value references its key keeping the key from ever being garbage. > The only reason the weak map was added was to allow internal code to get > the AutoSerializableManager given a ReflectionBasedAutoSerializer. > But the map was not really needed since the ReflectionBasedAutoSerializer > has a final field named "manager". > The only problem is that ReflectionBasedAutoSerializer is a public > api and AutoSerializableManager is internal. > This fix adds a getManager method on ReflectionBasedAutoSerializer that > returns object > and is javadoc'd for "internal use only". The internal code casts the result > to > AutoSerializableManager. This allows the weak map that was causing the memory > leak > to be removed. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheConfig.java > 60b765c4ae6c362e29119e9642710e217a7292e6 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java > f5be1444e2504dc92f191512ce41c87b798a40a8 > > gemfire-core/src/main/java/com/gemstone/gemfire/pdx/ReflectionBasedAutoSerializer.java > 7065cea7240ad21280edd4947a64ba10135dd6ae > > gemfire-core/src/main/java/com/gemstone/gemfire/pdx/internal/AutoSerializableManager.java > e7a7ab7bc3262b098dfd1ad6769f16263e8bbaf2 > > gemfire-core/src/main/java/com/gemstone/gemfire/pdx/internal/TypeRegistry.java > 4368e8496aa0637e305221d9e3373f34fa26b2bc > > gemfire-core/src/test/java/com/gemstone/gemfire/pdx/AutoSerializableJUnitTest.java > e3ab9ca1de093bc496facd4ed2c5f948721a51f4 > > Diff: https://reviews.apache.org/r/37193/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Darrel Schneider > >
