----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37321/#review94825 -----------------------------------------------------------
Ship it! Ship It! - Kirk Lund On Aug. 10, 2015, 10:02 p.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37321/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2015, 10:02 p.m.) > > > Review request for geode and Kirk Lund. > > > Bugs: GEODE-138 > https://issues.apache.org/jira/browse/GEODE-138 > > > Repository: geode > > > Description > ------- > > The race due to the test expecting local event delivery to be synchronous > but the implementation of off-heap resource manager events being async. > The test has been changed to always use a wait criteria when waiting > for a memory event to arrive. > > > Diffs > ----- > > > gemfire-core/src/test/java/com/gemstone/gemfire/cache/management/MemoryThresholdsOffHeapDUnitTest.java > 0b704a6955e641e249c00fc0942d4bca214ebbaf > > Diff: https://reviews.apache.org/r/37321/diff/ > > > Testing > ------- > > Ran MemoryThresholdsOffHeapDUnitTest (it was the only thing modified by this > fix). > > > Thanks, > > Darrel Schneider > >
